packages/cozy-search/src/locales/ru.json-51-51 (1)

51-51: ⚠️ Potential issue | 🟡 Minor

Russian pluralization requires 3 forms, but only 2 are provided.

Russian uses three plural forms (one / few / many). The items_selected key has only two forms. Compare with sources on line 14, which correctly provides three. The current form will produce incorrect text for counts like 1 or 5+.

🐛 Suggested fix

-      "items_selected": "Выбрано %{smart_count} элемента |||| Выбрано %{smart_count} элементов",
+      "items_selected": "Выбран %{smart_count} элемент |||| Выбрано %{smart_count} элемента |||| Выбрано %{smart_count} элементов",

packages/cozy-search/src/actions/rename.jsx-36-36 (1)

36-36: ⚠️ Potential issue | 🟡 Minor

Fix Prettier formatting error — CI is failing.

There's an extra space on this line that Prettier flags. This is blocking the pipeline.

-    action: () => { }
+    action: () => {}

packages/cozy-search/src/components/TwakeKnowledges/DriveKnowledge.jsx-32-37 (1)

32-37: ⚠️ Potential issue | 🟡 Minor

Select-all/clear counts diverge from the rendered list.

The "select all" checkbox on Lines 47-49 considers all items, but the collapsed list only renders customItems (Lines 83-102), which filters out IDs 'my-drive' and 'shared-with-me'. Currently none of the hard-coded items carry those IDs, making the filter dead code. If items with those IDs are ever passed in, the checkbox will toggle items the user can't see.

Either remove the customItems filter and render all items, or make the checkbox logic operate on customItems too.

packages/cozy-search/src/components/Search/SearchConversation.jsx-41-50 (1)

41-50: ⚠️ Potential issue | 🟡 Minor

Fallback to Date.now() silently places conversations without updatedAt into the "today" group.

Line 43 uses Date.now() as fallback when conv.cozyMetadata?.updatedAt is missing. This means any conversation lacking metadata will always appear under "Recent," regardless of when it was actually created. Consider using conv.cozyMetadata?.createdAt as a secondary fallback, or placing such conversations in the "older" group by default.

packages/cozy-search/src/components/Conversations/ConversationListItem.jsx-81-85 (1)

81-85: ⚠️ Potential issue | 🟡 Minor

Missing optional chaining on conversation.cozyMetadata — potential runtime crash.

Line 82 accesses conversation.cozyMetadata.updatedAt without optional chaining. If cozyMetadata is undefined (e.g., for a newly created or malformed conversation), this will throw a TypeError.

Proposed fix

             {formatConversationDate(
-              conversation.cozyMetadata.updatedAt,
+              conversation.cozyMetadata?.updatedAt,
               t,
               lang
             )}

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgePanel.jsx-134-136 (1)

134-136: ⚠️ Potential issue | 🟡 Minor

Missing alt attribute on <img> — accessibility issue.

Line 135 renders <img src={getIcon()} className="u-mr-1" /> without an alt attribute. This is an accessibility gap and may also trigger lint warnings. Add a descriptive alt or use alt="" if decorative.

Proposed fix

-        <img src={getIcon()} className="u-mr-1" />
+        <img src={getIcon()} className="u-mr-1" alt="" />

packages/cozy-search/src/components/TwakeKnowledges/MailKnowledge.jsx-179-187 (1)

179-187: ⚠️ Potential issue | 🟡 Minor

count={3} is hardcoded and disconnected from the actual item count.

The count prop should derive from the data:

Proposed fix

       <MailSection
         title={t('assistant.twake_knowledges.inbox')}
         icon={EmailIcon}
-        count={3}
+        count={inboxItems.length}
         items={inboxItems}

packages/cozy-search/src/components/TwakeKnowledges/MailKnowledge.jsx-75-75 (1)

75-75: ⚠️ Potential issue | 🟡 Minor

{count && <span>...} will render 0 to the DOM if count is 0.

This is a common React gotcha with the && short-circuit pattern for numbers. Use an explicit boolean check:

Proposed fix

-            {count && <span className={styles['badge']}>{count}</span>}
+            {count > 0 && <span className={styles['badge']}>{count}</span>}

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgePanel.jsx-179-181 (1)

179-181: ⚠️ Potential issue | 🟡 Minor

Fix formatting to pass CI.

The build pipeline reports extra whitespace on lines 180-181. Apply the formatter to fix:

Proposed fix

             label={
               openedKnowledgePanel === 'drive'
                 ? t('assistant.twake_knowledges.select_folders')
-                : openedKnowledgePanel === 'mail'
-                  ? t('assistant.twake_knowledges.select_emails')
-                  : t('assistant.twake_knowledges.select_messages')
+                : openedKnowledgePanel === 'mail'
+                ? t('assistant.twake_knowledges.select_emails')
+                : t('assistant.twake_knowledges.select_messages')
             }

packages/cozy-search/src/components/CozyAssistantRuntimeProvider.tsx-74-74 (1)

74-74: ⚠️ Potential issue | 🟡 Minor

CI failure: missing return types on functions.

The build pipeline requires explicit return types on these functions. Add the appropriate return type annotations to satisfy the linter.

• Line 74: ConversationLoader — JSX.Element | null
• Line 112: CozyAssistantRuntimeProviderInner — JSX.Element
• Line 261: cleanup callback — void
• Line 279: CozyAssistantRuntimeProvider — JSX.Element | null

Also applies to: 112-112, 261-261, 279-279

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgeSelector.jsx-49-51 (1)

49-51: ⚠️ Potential issue | 🟡 Minor

Missing alt attribute on chip icon images.

The <img> elements lack alt text, which hinders accessibility. Add an empty alt="" if decorative, or a descriptive label.

Proposed fix

-               <img src={twakeKnowledge.icon} className="u-h-1 u-ml-half" />
+               <img src={twakeKnowledge.icon} alt="" className="u-h-1 u-ml-half" />

packages/cozy-search/src/components/Conversations/ConversationListItemWider.jsx-89-91 (1)

89-91: ⚠️ Potential issue | 🟡 Minor

Potential crash if conversation.cozyMetadata is undefined.

If a conversation document lacks cozyMetadata, accessing .updatedAt will throw. Add optional chaining.

Proposed fix

-       {formatConversationDate(conversation.cozyMetadata.updatedAt, t, lang)}
+       {formatConversationDate(conversation.cozyMetadata?.updatedAt, t, lang)}

packages/cozy-search/src/actions/share.jsx-36-36 (1)

36-36: ⚠️ Potential issue | 🟡 Minor

Fix formatting: remove extra whitespace.

The linter flags a formatting violation here. Also, the action is a no-op — if the share feature isn't implemented yet, consider adding a TODO comment to clarify intent.

Proposed fix

-    action: () => { }
+    // TODO: implement share action
+    action: () => {}

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgeSelector.jsx-70-72 (1)

70-72: ⚠️ Potential issue | 🟡 Minor

Margin applied to the wrong last item when a chip is hidden by feature flag.

index is relative to the filtered array, but twakeKnowledges.length is the unfiltered array length. When the chat chip is hidden, the last visible chip still receives u-mr-half, causing a trailing gap.

Proposed fix

Store the filtered array first and use its length:

+ const filteredKnowledges = twakeKnowledges.filter(k => k.display)
+
  return (
    <div className="u-flex u-flex-row u-flex-wrap u-flex-items-center u-flex-justify-end">
-     {twakeKnowledges
-       .filter(twakeKnowledge => twakeKnowledge.display)
-       .map((twakeKnowledge, index) => {
+     {filteredKnowledges.map((twakeKnowledge, index) => {
          ...
              className={cx('u-mr-0', styles['knowledge-chips-item'], {
-               'u-mr-half': index < twakeKnowledges.length - 1
+               'u-mr-half': index < filteredKnowledges.length - 1
              })}

packages/cozy-search/src/types.d.ts (2)

24-28: useEventListener handler signature drops the event parameter.

The handler is typed as () => void, but event listener callbacks typically receive an Event argument. Consumers passing (e) => { e.preventDefault(); ... } would see a type mismatch.

Proposed fix

 declare module 'cozy-ui/transpiled/react/hooks/useEventListener' {
   // eslint-disable-next-line `@typescript-eslint/no-explicit-any`
-  const useEventListener: (element: any, event: string, handler: () => void) => void
+  const useEventListener: (element: any, event: string, handler: (event: Event) => void) => void
   export default useEventListener
 }

---

50-56: useI18n return type may be missing polyglot.

The actual useI18n from twake-i18n also returns polyglot (used internally by useExtendI18n). If any consumer in this package ever needs it, the type would be incomplete. Fine for now if only t and lang are used.

packages/cozy-search/src/components/helpers.js (1)

66-75: Hardcoded hour12: true overrides locale preference.

Passing lang to toLocaleTimeString is good, but hour12: true forces 12-hour (AM/PM) format for all locales, including those that conventionally use 24-hour time (e.g., fr, ru, vi). Consider removing hour12 to let the locale decide, or use hourCycle only when explicitly needed.

♻️ Suggested fix

     const timeStr = date.toLocaleTimeString(lang, {
       hour: 'numeric',
-      minute: '2-digit',
-      hour12: true
+      minute: '2-digit'
     })

packages/cozy-search/src/components/AssistantProvider.jsx (1)

133-168: Context value grows large — consider splitting in the future.

The provider now exposes 18+ values. Every state change re-creates the context object and re-renders all consumers. This isn't a regression (it follows the existing pattern), but as the surface keeps growing, consider splitting into separate contexts (e.g., a TwakeKnowledgeContext) to limit unnecessary re-renders.

packages/cozy-search/src/components/Messages/UserMessage.jsx (1)

19-23: Inline component re-created on every render.

The Text component passed to MessagePrimitive.Parts is an anonymous arrow function, so it's recreated each render. This can cause unnecessary unmount/remount cycles for the rendered elements. Extract it to a stable reference.

♻️ Suggested fix

+const TextPart = ({ text }) => <Typography>{text}</Typography>
+
 const UserMessage = () => {
   return (
     <MessagePrimitive.Root className="u-mt-1">
       <Card
         className={cx(
           'u-bg-paleGrey u-bdrs-5 u-bdw-0 u-ml-auto u-p-half',
           styles['cozyThread-user-messages']
         )}
       >
         <MessagePrimitive.Parts
           components={{
-            Text: ({ text }) => <Typography>{text}</Typography>
+            Text: TextPart
           }}
         />
       </Card>
     </MessagePrimitive.Root>
   )
 }

packages/cozy-search/src/components/adapters/StreamBridge.ts (1)

75-95: Missing return() method on the async iterator.

When a for await...of loop exits early (via break, throw, or return), the runtime calls iterator.return(). Without it, the stream won't self-clean. Currently mitigated because the adapter calls cleanup() explicitly, but adding return() would make the iterator protocol-complete and safer for other consumers.

Suggested addition

       [Symbol.asyncIterator]() {
         return this
-      }
+      },
+      return(): Promise<IteratorResult<string>> {
+        isDone = true
+        return Promise.resolve({ value: undefined as unknown as string, done: true })
+      }
     }

packages/cozy-search/package.json (1)

17-18: Both classnames and clsx are listed — they serve the same purpose.

These two libraries are functionally equivalent for conditional class name joining. Consider consolidating on one (preferably clsx since it's smaller) to avoid redundancy.

packages/cozy-search/src/components/styles.styl (1)

19-21: Consider using 100dvh instead of 100vh for mobile viewport accuracy.

100vh on mobile browsers includes the URL bar area, which can cause content to be clipped or scrollbars to appear unexpectedly. 100dvh (dynamic viewport height) adjusts for the actual visible area. If this view targets mobile as well, consider:

 .assistantWrapper
-  height calc(100vh - 48px)
+  height calc(100dvh - 48px)

If only desktop is targeted, 100vh is fine.

packages/cozy-search/src/components/Assistant/AssistantSelectionItem.jsx (1)

12-12: Simplify the import path — this file is already in the Assistant/ directory.

Since AssistantSelectionItem.jsx is located in components/Assistant/, the import ../Assistant/AssistantAvatar unnecessarily traverses up and back into the same directory. Use a direct sibling import instead.

Proposed fix

-import AssistantAvatar from '../Assistant/AssistantAvatar'
+import AssistantAvatar from './AssistantAvatar'

packages/cozy-search/src/components/TwakeKnowledges/styles.styl (2)

30-35: WebKit-only scrollbar styling won't apply in Firefox.

The ::-webkit-scrollbar rules are ignored by Firefox and other non-Chromium browsers. If consistent scrollbar styling matters, consider adding scrollbar-width: thin and scrollbar-color for Firefox.

Proposed addition for Firefox support

 .source-panel-content
   flex 1
   overflow-y auto
   padding 0 8px
+  scrollbar-width thin
+  scrollbar-color var(--dividerColor) transparent

   &::-webkit-scrollbar
     width 6px

---

46-51: Excessive !important usage across utility classes.

Many rules here use !important on nearly every property (e.g., .section-header, .nested-item, .clear-all-button). This is likely to override cozy-ui/Material UI defaults, but it makes future maintenance harder. Consider using more specific selectors or scoping via a parent class instead, where feasible.

packages/cozy-search/src/components/Assistant/AssistantContainer.jsx (1)

27-35: Hard-coded u-bg-white may break dark mode / theming.

Both the sidebar wrapper (Line 27) and the main content area (Line 33) use u-bg-white, while the stylesheets elsewhere (e.g., styles.styl) use var(--paperBackgroundColor) for theme compatibility. Consider using a theme-aware background utility or CSS variable instead.

packages/cozy-search/src/index.ts (1)

7-12: Public API additions look reasonable.

One note: CozyComposer (Line 10) re-exports ConversationComposer — the naming mismatch between the public alias and the internal module name may cause confusion when navigating between consumer code and source. Consider aligning the names.

packages/cozy-search/src/components/Sidebar/index.jsx (1)

28-32: No loading or error state for the conversations query.

When conversations is undefined (loading) or the query fails, the sidebar shows nothing. Consider showing a spinner or skeleton while loading, and handling the error case for better UX.

packages/cozy-search/src/components/TwakeKnowledges/ChatKnowledge.jsx (1)

17-22: Hardcoded mock data should be replaced with real data or clearly marked as placeholder.

The chats array is hardcoded with static entries ('Team Discussion', 'Project Updates', etc.). Unlike the conversation queries used elsewhere (e.g., buildChatConversationsQuery in SearchConversation.jsx), this component doesn't fetch real data. If this is intentional scaffolding for a future integration, consider adding a // TODO comment. If it should already be dynamic, wire it to a query or accept it as a prop.

Additionally, since this array is static, move it outside the component to avoid re-creating it on every render.

Proposed minimal fix

+const CHATS = [
+  { id: 'chat1', name: 'Team Discussion' },
+  { id: 'chat2', name: 'Project Updates' },
+  { id: 'chat3', name: 'General Chat' },
+  { id: 'chat4', name: 'Support' }
+]
+
 const ChatKnowledge = ({ selectedItems, onToggleItems, onClearItems }) => {
   const { t } = useI18n()
-  const chats = [
-    { id: 'chat1', name: 'Team Discussion' },
-    { id: 'chat2', name: 'Project Updates' },
-    { id: 'chat3', name: 'General Chat' },
-    { id: 'chat4', name: 'Support' }
-  ]
+  // TODO: Replace with real data from API
+  const chats = CHATS

packages/cozy-search/src/components/Search/SearchConversation.jsx (2)

58-62: SearchBar is not wired to any search/filter logic.

The SearchBar renders but has no onChange, onSearch, or value binding. It's currently non-functional. If this is intentional scaffolding, a // TODO comment would help. Otherwise, it should be wired to filter conversations before grouping.

---

20-24: buildChatConversationsQuery() is called on every render without memoization.

Each call returns a fresh object. While cozy-client's useQuery likely deduplicates by the as key, it's a good practice to stabilize the reference (e.g., call it outside the component or wrap in useMemo).

Proposed fix

 const SearchConversation = () => {
   const { t } = useI18n()
   const { createNewConversation, goToConversation } = useConversation()

-  const conversationsQuery = buildChatConversationsQuery()
+  const conversationsQuery = useMemo(() => buildChatConversationsQuery(), [])
   const { data: conversations } = useQuery(
     conversationsQuery.definition,
     conversationsQuery.options
   )

packages/cozy-search/src/components/Conversations/ConversationListItem.jsx (1)

35-35: makeActions is called on every render.

makeActions([share, rename, remove], { t }) creates a new actions array each render. Consider memoizing it with useMemo:

Proposed fix

-  const actions = makeActions([share, rename, remove], { t })
+  const actions = useMemo(() => makeActions([share, rename, remove], { t }), [t])

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgePanel.jsx (1)

90-127: Three parallel switch statements on openedKnowledgePanel can be consolidated into a config map.

getTitle, getDescription, and getIcon all switch on the same key. A single lookup object would be more maintainable and eliminate the repetition:

Proposed refactor

+const PANEL_CONFIG = {
+  drive: { titleKey: 'title_drive', descKey: 'desc_drive', icon: TDrive },
+  mail: { titleKey: 'title_mail', descKey: 'desc_mail', icon: TMail },
+  chat: { titleKey: 'title_chat', descKey: 'desc_chat', icon: TChat }
+}

 // Inside the component:
-  const getTitle = () => { ... }
-  const getDescription = () => { ... }
-  const getIcon = () => { ... }
+  const config = PANEL_CONFIG[openedKnowledgePanel] || {}
+  const title = config.titleKey ? t(`assistant.twake_knowledges.${config.titleKey}`) : t('assistant.twake_knowledges.title_default')
+  const description = config.descKey ? t(`assistant.twake_knowledges.${config.descKey}`) : ''
+  const icon = config.icon || null

packages/cozy-search/src/components/Views/AssistantDialog.jsx (2)

62-62: Redundant ternary — both branches are identical.

title={isMobile ? ' ' : ' '} always evaluates to ' '. Simplify to title=" ".

Proposed fix

-      title={isMobile ? ' ' : ' '}
+      title=" "

---

53-60: Inline style on dialogContent — consider using a CSS class.

The rest of the component uses utility classes and .styl modules for styling. The inline style object on dialogContent (lines 54-59) is inconsistent with that pattern and will create a new object reference on every render.

packages/cozy-search/src/components/TwakeKnowledges/MailKnowledge.jsx (1)

143-165: Hardcoded mock data — same concern as ChatKnowledge.jsx.

inboxItems and starredItems are hardcoded with placeholder email data. If this is intentional scaffolding, add // TODO comments to indicate these should be replaced with real data fetches. Also, these arrays are re-created on every render — move them outside the component if they remain static for now.

Also applies to: 167-175

packages/cozy-search/src/components/Assistant/AssistantAvatar.jsx (1)

14-52: Consider extracting the repeated className computation.

The same cx(styles['assistant-icon'], { [styles['assistant-icon--small']]: isSmall }, className) expression is duplicated across all three branches. Extracting it into a variable would reduce repetition and make future changes less error-prone.

Proposed refactor

 const AssistantAvatar = ({ assistant, isSmall, className }) => {
   if (!assistant) return null
 
+  const iconClassName = cx(
+    styles['assistant-icon'],
+    { [styles['assistant-icon--small']]: isSmall },
+    className
+  )
+
   if (assistant.id !== DEFAULT_ASSISTANT.id && !assistant.icon) {
     return (
       <Icon
         icon={AssistantIcon}
-        className={cx(
-          styles['assistant-icon'],
-          {
-            [styles['assistant-icon--small']]: isSmall
-          },
-          className
-        )}
+        className={iconClassName}
       />
     )
   }

Apply the same replacement for the other two branches.

packages/cozy-search/src/components/Conversations/ConversationListItemWider.jsx (1)

38-38: makeActions is called on every render.

This creates new action instances and a new array reference on each render, which can trigger unnecessary re-renders of ActionsMenu. Consider memoizing with useMemo.

Proposed fix

- const actions = makeActions([share, rename, remove], { t })
+ const actions = useMemo(() => makeActions([share, rename, remove], { t }), [t])

Add useMemo to the React import on line 2.

packages/cozy-search/src/components/Conversations/Conversation.jsx (1)

16-19: Unnecessary spread destructure.

{ ...queryMyselfResult } creates a shallow copy for no apparent benefit. This looks like a leftover from when data was extracted. Simplify to a direct assignment.

Proposed fix

- const { ...queryMyselfResult } = useQuery(
+ const queryMyselfResult = useQuery(
    myselfQuery.definition,
    myselfQuery.options
  )

packages/cozy-search/src/components/CozyAssistantRuntimeProvider.tsx (2)

114-114: new StreamBridge() runs on every render.

useRef(new StreamBridge()) evaluates the constructor on each render, discarding the result after the first. Use lazy initialization to avoid wasteful allocations.

Proposed fix

- const streamBridgeRef = useRef(new StreamBridge())
+ const streamBridgeRef = useRef<StreamBridge | null>(null)
+ if (!streamBridgeRef.current) {
+   streamBridgeRef.current = new StreamBridge()
+ }

---

122-124: useEffect with empty deps references initialMessages.

The effect reads initialMessages but has [] as deps, so it only runs on mount. This is intentionally "run once," but it will trigger an ESLint react-hooks/exhaustive-deps warning. Suppress it explicitly to signal intent.

Proposed fix

  useEffect(() => {
    messagesIdRef.current = initialMessages.map(m => m.id).filter((id): id is string => !!id)
+ // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [])

packages/cozy-search/src/components/Assistant/AssistantSelectionItem.jsx (1)

12-12: Unnecessary path traversal — file is already in Assistant/.

Since AssistantSelectionItem.jsx lives in the Assistant directory, ../Assistant/AssistantAvatar goes up a level only to come back into the same folder. A direct relative import is cleaner.

Suggested fix

-import AssistantAvatar from '../Assistant/AssistantAvatar'
+import AssistantAvatar from './AssistantAvatar'

packages/cozy-search/src/components/TwakeKnowledges/styles.styl (2)

43-64: Excessive !important usage suggests specificity conflicts.

Nearly every property in .section-header, .nested-item, and .clear-all-button uses !important. This typically indicates fighting against a UI library's inline styles or high-specificity selectors. While it works, it makes future style overrides very difficult and is fragile to upstream changes.

Consider whether these classes can be applied with higher specificity selectors (e.g., .source-panel .section-header) or by using the UI library's built-in styling/theming mechanisms (e.g., sx prop, classes override) instead of !important.

---

30-35: WebKit-only scrollbar styling.

The ::-webkit-scrollbar pseudo-elements only work in Chromium/WebKit browsers. Firefox users will see the default scrollbar. If cross-browser custom scrollbar styling matters, consider adding scrollbar-width: thin and scrollbar-color for Firefox support.

Proposed addition for Firefox support

 .source-panel-content
   flex 1
   overflow-y auto
   padding 0 8px
+  scrollbar-width thin
+  scrollbar-color var(--dividerColor) transparent

   &::-webkit-scrollbar
     width 6px

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgePanel.jsx (1)

90-127: Three parallel switch statements on the same key can be consolidated into a config map.

getTitle, getDescription, and getIcon all switch on openedKnowledgePanel with identical cases. A single lookup object would reduce duplication and make adding new panels trivial.

Suggested refactor

+const PANEL_CONFIG = {
+  drive: { titleKey: 'title_drive', descKey: 'desc_drive', icon: TDrive },
+  mail:  { titleKey: 'title_mail',  descKey: 'desc_mail',  icon: TMail },
+  chat:  { titleKey: 'title_chat',  descKey: 'desc_chat',  icon: TChat }
+}
+
 const TwakeKnowledgePanel = ({ onClose }) => {
   const { t } = useI18n()
   // ...
+  const panelConfig = PANEL_CONFIG[openedKnowledgePanel] || {}
+  const title = t(`assistant.twake_knowledges.${panelConfig.titleKey || 'title_default'}`)
+  const description = panelConfig.descKey ? t(`assistant.twake_knowledges.${panelConfig.descKey}`) : ''
+  const icon = panelConfig.icon || null

Then use title, description, and icon directly in the JSX, removing the three getX functions.

packages/cozy-search/package.json (1)

17-18: Remove clsx from direct dependencies—it's pulled in transitively by class-variance-authority.

classnames is actively used throughout the codebase (15+ files), while clsx has zero direct imports. Since class-variance-authority already declares clsx as a dependency, there's no reason to list it as a direct dependency.

packages/cozy-search/src/components/Conversations/Conversation.jsx (1)

16-16: Unnecessary spread destructure.

const { ...queryMyselfResult } is equivalent to const queryMyselfResult = useQuery(...). The spread-into-rest adds no value here.

♻️ Simplify

-  const { ...queryMyselfResult } = useQuery(
+  const queryMyselfResult = useQuery(
     myselfQuery.definition,
     myselfQuery.options
   )

packages/cozy-search/src/components/Conversations/ConversationBar.jsx (1)

77-100: IconButton wrapping Button is redundant nesting.

Both IconButton and Button are interactive controls. While component="div" on the inner Button avoids an illegal nested <button>, the IconButton wrapper serves no visible purpose — it adds an extra DOM node and click target that doesn't contribute styling or semantics beyond what the Button already provides. Consider using just one of the two.

Simplify by removing the IconButton wrapper

-            endAdornment: isRunning ? (
-              <IconButton className="u-p-0 u-mr-half">
-                <Button
-                  size="small"
-                  component="div"
-                  className="u-miw-auto u-w-2 u-h-2 u-bdrs-circle"
-                  classes={{ label: 'u-flex u-w-auto' }}
-                  label={<Icon icon={StopIcon} size={12} />}
-                  onClick={onCancel}
-                />
-              </IconButton>
-            ) : (
-              <IconButton className="u-p-0 u-mr-half">
-                <Button
-                  size="small"
-                  component="div"
-                  className="u-miw-auto u-w-2 u-h-2 u-bdrs-circle"
-                  classes={{ label: 'u-flex u-w-auto' }}
-                  label={<Icon icon={PaperplaneIcon} size={12} rotate={-45} />}
-                  disabled={isEmpty}
-                  onClick={handleSend}
-                />
-              </IconButton>
+            endAdornment: isRunning ? (
+              <Button
+                size="small"
+                className="u-miw-auto u-w-2 u-h-2 u-bdrs-circle u-mr-half"
+                classes={{ label: 'u-flex u-w-auto' }}
+                label={<Icon icon={StopIcon} size={12} />}
+                onClick={onCancel}
+              />
+            ) : (
+              <Button
+                size="small"
+                className="u-miw-auto u-w-2 u-h-2 u-bdrs-circle u-mr-half"
+                classes={{ label: 'u-flex u-w-auto' }}
+                label={<Icon icon={PaperplaneIcon} size={12} rotate={-45} />}
+                disabled={isEmpty}
+                onClick={handleSend}
+              />
             ),

packages/cozy-search/src/actions/delete.jsx (1)

9-24: Duplicated makeComponent across delete, share, and rename action files.

The makeComponent function is nearly identical in delete.jsx, share.jsx, and rename.jsx. The only variations are the className prop and displayName. Consider extracting a shared factory that accepts { displayName, className } to reduce duplication.

♻️ Shared factory sketch (e.g., in a new `makeActionComponent.jsx`)

import React, { forwardRef } from 'react'
import ActionsMenuItem from 'cozy-ui/transpiled/react/ActionsMenu/ActionsMenuItem'
import Icon from 'cozy-ui/transpiled/react/Icon'
import ListItemIcon from 'cozy-ui/transpiled/react/ListItemIcon'
import ListItemText from 'cozy-ui/transpiled/react/ListItemText'

export const makeActionComponent = (label, icon, { displayName, className } = {}) => {
  const Component = forwardRef((props, ref) => (
    <ActionsMenuItem className={className} {...props} ref={ref}>
      <ListItemIcon>
        <Icon className={className} icon={icon} />
      </ListItemIcon>
      <ListItemText primary={label} />
    </ActionsMenuItem>
  ))
  Component.displayName = displayName || 'ActionComponent'
  return Component
}

packages/cozy-search/src/components/adapters/StreamBridge.ts (2)

75-95: Consider adding a return() method on the async iterator.

The iterator lacks a return() method, which means if a consumer uses break in a for await loop or the loop is otherwise interrupted, the iterator's internal cleanup won't run automatically per the async iterator protocol. Currently, the adapter handles this externally via streamBridge.cleanup(), so it works in practice. However, implementing return() would make the iterator self-contained and safer for any future consumers.

♻️ Proposed addition

       iterator: {
         next: (): Promise<IteratorResult<string>> =>
           new Promise((resolve, reject) => {
             // ... existing logic
           }),
+        return: (): Promise<IteratorResult<string>> => {
+          if (!isDone) {
+            isDone = true
+            if (resolveNext) {
+              resolveNext({ value: undefined as unknown as string, done: true })
+              resolveNext = null
+              rejectNext = null
+            }
+          }
+          return Promise.resolve({ value: undefined as unknown as string, done: true })
+        },
         [Symbol.asyncIterator]() {
           return this
         }
       }

---

16-18: cleanupCallback is a single global callback, not per-conversation.

If StreamBridge is ever used to manage multiple simultaneous conversations, the single cleanupCallback will fire for any conversation's cleanup. Currently the provider uses one conversation at a time (route-driven), so this is fine — just noting for future awareness.

packages/cozy-search/src/components/CozyAssistantRuntimeProvider.tsx (1)

122-124: Missing dependency in useEffect will trigger exhaustive-deps lint warning.

initialMessages is used inside the effect but not listed in the dependency array. While the intent (run on mount only) is valid since this component is remounted per conversation, the empty [] will trigger a React lint warning. Suppress it explicitly to signal intent.

♻️ Proposed fix

   useEffect(() => {
     messagesIdRef.current = initialMessages.map(m => m.id).filter((id): id is string => !!id)
-  }, [])
+  // eslint-disable-next-line react-hooks/exhaustive-deps -- intentionally run only on mount; initialMessages is stable for this component's lifetime
+  }, [])

packages/cozy-search/src/components/styles.styl (1)

20-21: Magic number 48px — consider using a CSS variable or a comment.

The 48px presumably corresponds to a header/toolbar height. A brief comment or a shared CSS variable (e.g., --header-height) would improve maintainability and make the coupling explicit.

Also note that 100vh on mobile browsers doesn't account for the dynamic address bar. If mobile support matters, 100dvh (dynamic viewport height) is more reliable, though it requires checking your browser support targets.

packages/cozy-search/src/components/Sidebar/index.jsx (1)

28-32: buildChatConversationsQuery() is re-invoked on every render.

Consider hoisting the query outside the component or wrapping in useMemo to avoid rebuilding the query descriptor object each render cycle. It's functionally harmless (useQuery caches by options.as), but it's a cheap win for clarity.

Proposed fix

+const conversationsQuery = buildChatConversationsQuery()
+
 const Sidebar = () => {
   ...
-  const conversationsQuery = buildChatConversationsQuery()
   const { data: conversations } = useQuery(
     conversationsQuery.definition,
     conversationsQuery.options
   )

packages/cozy-search/src/components/Views/AssistantDialog.jsx (1)

62-62: Redundant ternary — both branches are identical.

isMobile ? ' ' : ' ' evaluates to ' ' in all cases. If the title should differ between mobile and desktop, update accordingly; otherwise simplify.

Proposed fix

-      title={isMobile ? ' ' : ' '}
+      title=" "

packages/cozy-search/src/components/Conversations/ConversationListItemWider.jsx (1)

38-38: makeActions is recomputed on every render.

Consider memoizing with useMemo since the inputs (t) only change on locale switch.

Proposed fix

-  const actions = makeActions([share, rename, remove], { t })
+  const actions = useMemo(() => makeActions([share, rename, remove], { t }), [t])

Add useMemo to the React import on Line 2.

packages/cozy-search/src/components/Messages/UserMessage.jsx (1)

19-23: Extract the inline Text component to a stable reference.

The anonymous arrow function passed as Text creates a new component identity on every render, which can cause unnecessary unmount/remount cycles. Define it outside UserMessage.

♻️ Proposed fix

+const Text = ({ text }) => <Typography>{text}</Typography>
+
 const UserMessage = () => {
   return (
     <MessagePrimitive.Root className="u-mt-1">
       <Card
         className={cx(
           'u-bg-paleGrey u-bdrs-5 u-bdw-0 u-ml-auto u-p-half',
           styles['cozyThread-user-messages']
         )}
       >
         <MessagePrimitive.Parts
           components={{
-            Text: ({ text }) => <Typography>{text}</Typography>
+            Text
           }}
         />
       </Card>
     </MessagePrimitive.Root>
   )
 }

packages/cozy-search/src/types.d.ts (1)

24-28: handler type is too restrictive — it should accept an event parameter.

The handler is typed as () => void, but event listener callbacks typically receive an Event object. This will cause type errors for any caller that needs to read the event.

Proposed fix

 declare module 'cozy-ui/transpiled/react/hooks/useEventListener' {
-  const useEventListener: (element: any, event: string, handler: () => void) => void
+  const useEventListener: (element: any, event: string, handler: (event: Event) => void) => void
   export default useEventListener
 }

packages/cozy-search/src/components/helpers.js (1)

49-51: No validation for invalid date strings.

new Date('garbage') produces an Invalid Date object, and subsequent comparisons and toLocaleTimeString/toLocaleDateString calls will return "Invalid Date" strings rendered in the UI. A quick guard would prevent this.

Proposed fix

 export const formatConversationDate = (dateString, t, lang) => {
   if (!dateString) return ''
   const date = new Date(dateString)
+  if (isNaN(date.getTime())) return ''
   const now = new Date()

packages/cozy-search/src/components/TwakeKnowledges/styles.styl (1)

1-93: Stylesheet looks reasonable for the panel layout.

The Stylelint error on line 2 is a false positive — Stylus syntax doesn't use colons for property-value pairs.

The heavy !important usage throughout (lines 46–47, 49–51, 54–60, 84–85, 88, 91–93) suggests overriding component library defaults. This works but can become fragile if upstream styles change. Consider scoping via more specific selectors where feasible.

packages/cozy-search/src/components/TwakeKnowledges/MailKnowledge.jsx (1)

24-139: MailSection and DriveSection are nearly identical — consider extracting a shared KnowledgeSection component.

Both components have the same collapsible header pattern, tri-state checkbox logic, clear-all button, and nested item list. The only differences are the item rendering (mail shows subject/from/preview/date; drive shows folder name). A shared wrapper accepting a custom renderItem prop would eliminate the duplication.

Also applies to: 18-107

packages/cozy-search/src/components/TwakeKnowledges/DriveKnowledge.jsx (1)

35-37: customItems filter is dead code — no items currently have IDs 'my-drive' or 'shared-with-me'.

The hardcoded items use IDs like 'doc1', 'proj1', etc., so this filter returns the same array as items. If this is forward-looking logic for real data, add a comment to clarify. Otherwise, it adds confusion.

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgePanel.jsx (1)

59-127: Four switch statements on openedKnowledgePanel — consolidate into a config map.

renderContent, getTitle, getDescription, and getIcon all switch on the same key. A single config object would eliminate the repetition and make adding new panel types a one-line change.

Suggested approach

+const PANEL_CONFIG = {
+  drive: {
+    component: DriveKnowledge,
+    titleKey: 'assistant.twake_knowledges.title_drive',
+    descKey: 'assistant.twake_knowledges.desc_drive',
+    icon: TDrive
+  },
+  mail: {
+    component: MailKnowledge,
+    titleKey: 'assistant.twake_knowledges.title_mail',
+    descKey: 'assistant.twake_knowledges.desc_mail',
+    icon: TMail
+  },
+  chat: {
+    component: ChatKnowledge,
+    titleKey: 'assistant.twake_knowledges.title_chat',
+    descKey: 'assistant.twake_knowledges.desc_chat',
+    icon: TChat
+  }
+}

Then use PANEL_CONFIG[openedKnowledgePanel] to look up all four values at once.

packages/cozy-search/src/components/Conversations/ConversationComposer.jsx (2)

26-28: handleSend has no empty-input guard — relies on ConversationBar for protection.

composerRuntime.send() is called unconditionally here. The guard (if (isEmpty) return) lives inside ConversationBar.handleSend (for button clicks) and ConversationBar.handleKeyDown (for Enter). This works for the current wiring, but if handleSend is ever called from a different path, an empty message could be dispatched. Consider adding a guard here as well, or document the assumption.

💡 Optional: add a local guard

  const handleSend = useCallback(() => {
+   if (isEmpty) return
    composerRuntime.send()
- }, [composerRuntime])
+ }, [composerRuntime, isEmpty])

---

61-66: Layout with single child when feature flag is off.

When cozy.create-assistant.enabled is false, only TwakeKnowledgeSelector renders inside the u-flex-justify-between container. A single child with justify-between behaves like justify-start, pushing the knowledge selector to the left. If the intent is to keep it right-aligned regardless, u-flex-justify-end would be more robust.

packages/cozy-search/src/components/Assistant/styles.styl (1)

23-36: Heavy use of !important for menu-item overrides.

Five !important declarations to override the base ActionsMenuItem styles suggests a specificity battle. This works but is fragile — any future cozy-ui update that adds its own !important will break these overrides. If possible, consider increasing specificity via nesting or a more specific selector instead.

packages/cozy-search/src/actions/share.jsx (2)

9-24: makeComponent is duplicated across share.jsx, rename.jsx, and delete.jsx.

The makeComponent helper in share.jsx and rename.jsx is identical. Even delete.jsx only differs by adding className="u-error". Consider extracting a shared makeActionComponent(label, icon, options?) utility to reduce duplication.

---

36-36: Share action is a no-op.

action: () => { } means clicking "Share" does nothing. If this is intentionally stubbed out for a future PR, consider adding a brief comment or a // TODO so it's not mistaken for a bug.

packages/cozy-search/src/actions/rename.jsx (1)

9-24: makeComponent is duplicated across action files.

This helper is identical in rename.jsx, delete.jsx, and share.jsx (per AI summary). Consider extracting it into a shared utility to reduce duplication. Low priority given the small footprint.

packages/cozy-search/src/components/Views/AssistantDialog.jsx (1)

53-60: Inline style object is re-created on every render.

The dialogContent.style object is a new reference each render, which can defeat shallow-comparison optimizations downstream. Consider extracting it as a module-level constant.

Proposed fix

+const dialogContentStyle = {
+  display: 'flex',
+  flexDirection: 'column',
+  flexGrow: 1,
+  padding: 0
+}
+
 const AssistantDialog = () => {
   ...
        dialogContent: {
-          style: {
-            display: 'flex',
-            flexDirection: 'column',
-            flexGrow: 1,
-            padding: 0
-          }
+          style: dialogContentStyle
        }

packages/cozy-search/src/components/CozyAssistantRuntimeProvider.tsx (2)

112-114: useEffect intentionally omits initialMessages from deps — add suppression comment.

This effect seeds messagesIdRef once on mount. The missing dependency is intentional, but a future contributor (or linter) may "fix" it and introduce a bug. An eslint-disable-next-line comment clarifies intent.

  useEffect(() => {
    messagesIdRef.current = initialMessages.map(m => m.id).filter((id): id is string => !!id)
+    // eslint-disable-next-line react-hooks/exhaustive-deps -- One-time initialization from initial load
  }, [])

---

66-95: ConversationLoader renders null during loading — consider a loading indicator.

Returning null while the conversation query loads means the user sees a blank screen. A spinner or skeleton would improve perceived responsiveness, especially on slow connections.

packages/cozy-search/src/components/Conversations/ConversationListItemWider.jsx (1)

38-38: actions array is recreated on every render.

makeActions(...) is called unconditionally on each render. Consider memoizing with useMemo keyed on t.

- const actions = makeActions([share, rename, remove], { t })
+ const actions = useMemo(() => makeActions([share, rename, remove], { t }), [t])

packages/cozy-search/src/components/adapters/CozyRealtimeChatAdapter.ts (1)

87-104: Abort is only checked between chunks, not proactively.

If the stream is blocked waiting for the next chunk (no data arriving), abortSignal.aborted won't be evaluated until the next for await iteration completes. For a responsive cancel, consider listening to abortSignal.addEventListener('abort', ...) to call streamBridge.cleanup() immediately. This is a minor UX concern — the stop button may feel unresponsive if the backend stalls.

packages/cozy-search/src/components/adapters/StreamBridge.ts (1)

24-26: cleanupCallback is a singleton shared across all conversations.

setCleanupCallback stores a single callback, not per-conversation. If StreamBridge were ever used for multiple concurrent conversations (e.g., prefetching), cleanup for one conversation would invoke the other's callback. Currently safe given the 1:1 provider-to-conversation relationship, but worth noting for future changes.

packages/cozy-search/src/types.d.ts (1)

50-56: useI18n return type is incomplete — missing polyglot.

The actual useI18n hook (see packages/twake-i18n/src/useExtendI18n.jsx) also returns polyglot in its return value, which is used by useExtendI18n. While current consumers in this PR only destructure t and lang, omitting polyglot from the type makes the declaration inaccurate and could cause type errors for future callers.

Proposed fix

 declare module 'twake-i18n' {
   export function useI18n(): {
     t: (key: string, options?: Record<string, unknown>) => string
     lang: string
+    polyglot: any
   }
   export function useExtendI18n(locales: Record<string, unknown>): void
 }

packages/cozy-search/src/components/styles.styl (1)

20-21: Consider documenting or extracting the magic 48px value.

The 48px offset presumably corresponds to a header/toolbar height. A comment clarifying what it accounts for would help future maintainers.

packages/cozy-search/src/components/Messages/UserMessage.jsx (1)

19-23: Extract the inline Text component to avoid re-creation on every render.

The inline ({ text }) => <Typography>{text}</Typography> creates a new component reference each render, which can cause MessagePrimitive.Parts to unmount/remount its children unnecessarily.

♻️ Proposed fix

Define the component outside UserMessage:

+const TextPart = ({ text }) => <Typography>{text}</Typography>
+
 const UserMessage = () => {
   return (
     <MessagePrimitive.Root className="u-mt-1">
       <Card
         className={cx(
           'u-bg-paleGrey u-bdrs-5 u-bdw-0 u-ml-auto u-p-half',
           styles['cozyThread-user-messages']
         )}
       >
         <MessagePrimitive.Parts
           components={{
-            Text: ({ text }) => <Typography>{text}</Typography>
+            Text: TextPart
           }}
         />
       </Card>
     </MessagePrimitive.Root>
   )
 }

packages/cozy-search/src/components/Messages/AssistantMessage.jsx (1)

15-15: Stabilize the useMessage selector to avoid potential extra re-renders.

If useMessage uses reference equality on the selector (common pattern), a new arrow function each render could cause unnecessary re-subscriptions.

♻️ Proposed fix

+const selectIsRunning = s => s.status?.type === 'running'
+
 const AssistantMessage = () => {
   const { t } = useI18n()
-  const isRunning = useMessage(s => s.status?.type === 'running')
+  const isRunning = useMessage(selectIsRunning)

packages/cozy-search/src/components/TwakeKnowledges/styles.styl (2)

43-93: Excessive !important usage and generic class names risk style collisions.

There are ~15 !important declarations, suggesting these styles are fighting the component library's specificity. Additionally, generic names like .badge, .section-header, .nested-item could easily clash with other styles in the app.

Consider:

1. Namespacing classes (e.g., .twakeKnowledge-badge, .twakeKnowledge-sectionHeader) to avoid collisions.
2. Investigating whether higher specificity selectors or component-level style overrides could replace !important.

---

30-35: WebKit-only scrollbar styling — Firefox users get default scrollbar.

The custom scrollbar is only styled with -webkit-scrollbar pseudo-elements. Consider adding scrollbar-width: thin and scrollbar-color for Firefox support.

♻️ Proposed fix

 .source-panel-content
   flex 1
   overflow-y auto
   padding 0 8px
+  scrollbar-width thin
+  scrollbar-color var(--dividerColor) transparent

   &::-webkit-scrollbar
     width 6px

packages/cozy-search/src/components/Assistant/styles.styl (1)

23-36: Consider reducing !important usage.

There are six !important annotations across .menu-item and .menu-item-icon-button. While sometimes necessary to override library (cozy-ui) defaults, heavy reliance on !important makes future style overrides difficult. Consider increasing specificity or using cozy-ui's own class overrides where possible.

packages/cozy-search/src/components/AssistantProvider.jsx (1)

133-168: Context is growing large — consider splitting concerns.

The AssistantContext now exposes 15+ values. Every state change (e.g., toggling isOpenSearchConversation) triggers re-renders for all consumers, even those that only use selectedAssistantId. Consider splitting into separate contexts (e.g., AssistantUIContext for UI state, AssistantKnowledgeContext for knowledge panel state) if performance becomes an issue.

packages/cozy-search/src/components/TwakeKnowledges/MailKnowledge.jsx (1)

143-175: Hard-coded data: add a TODO comment for replacement with real data.

Similar to DriveKnowledge.jsx, inboxItems and starredItems are temporary scaffolding. Add a // TODO: replace with real data source comment to track this, and plan for data fetching, error handling, and loading states.

Based on learnings: "In packages/cozy-search/src/components/TwakeKnowledges/DriveKnowledge.jsx, the hard-coded myDriveItems and sharedItems arrays are temporary scaffolding and will be replaced with real data later."

packages/cozy-search/src/components/CozyAssistantRuntimeProvider.tsx (1)

112-114: Suppress the exhaustive-deps lint warning for this intentional mount-only effect.

initialMessages is intentionally captured only at mount time, but ESLint's react-hooks/exhaustive-deps rule will flag it. Add a suppression comment to document the intent.

Proposed fix

   useEffect(() => {
     messagesIdRef.current = initialMessages.map(m => m.id).filter((id): id is string => !!id)
+  // eslint-disable-next-line react-hooks/exhaustive-deps -- intentionally capture initial value only
   }, [])

packages/cozy-search/src/components/Views/AssistantDialog.jsx (1)

53-60: Consider extracting inline styles to a CSS class.

The inline style object on dialogContent will create a new object reference on every render. Since you already import styles.styl, moving these declarations into a stylesheet class would be more consistent with the rest of the component.

packages/cozy-search/src/components/adapters/StreamBridge.ts (2)

74-94: Missing return() method on the async iterator.

The AsyncIterableIterator protocol optionally supports return() for early termination (e.g., break from for-await-of). Without it, breaking out of a consuming loop won't signal the bridge to clean up the stream.

Proposed addition

         [Symbol.asyncIterator]() {
           return this
-        }
+        },
+        return(): Promise<IteratorResult<string>> {
+          isDone = true
+          return Promise.resolve({ value: undefined as unknown as string, done: true })
+        }

---

63-72: Queued chunks are discarded on error.

When error() is called, isDone is set to true and the error is stored. Since next() checks error before draining the queue (line 77), any buffered chunks are lost. If partial delivery matters, consider draining the queue before rejecting. If discarding is intentional, a brief comment would clarify the design choice.

packages/cozy-search/src/actions/share.jsx (2)

9-24: makeComponent is duplicated across share.jsx, rename.jsx, and delete.jsx.

All three action files define nearly identical makeComponent factories (differing only in displayName and optional class names like u-error for delete). Consider extracting a shared helper, e.g. makeActionComponent(displayName, className), to reduce duplication.

---

36-36: action is a no-op — add a TODO comment.

The share action handler does nothing. If this is intentional WIP, a // TODO: implement share action comment would signal intent to future maintainers.

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgePanel.jsx (1)

90-127: Consolidate repeated switch statements into a config map.

getTitle, getDescription, and getIcon all switch on the same openedKnowledgePanel value. A single lookup object would reduce repetition and make adding new panel types easier.

Example refactor

+const PANEL_CONFIG = {
+  drive: { icon: TDrive, titleKey: 'title_drive', descKey: 'desc_drive' },
+  mail: { icon: TMail, titleKey: 'title_mail', descKey: 'desc_mail' },
+  chat: { icon: TChat, titleKey: 'title_chat', descKey: 'desc_chat' }
+}
+
 const TwakeKnowledgePanel = ({ onClose }) => {
   // ...
+  const config = PANEL_CONFIG[openedKnowledgePanel]
+  const title = config ? t(`assistant.twake_knowledges.${config.titleKey}`) : t('assistant.twake_knowledges.title_default')
+  const description = config ? t(`assistant.twake_knowledges.${config.descKey}`) : ''
+  const icon = config?.icon ?? null

packages/cozy-search/src/components/Conversations/ConversationListItem.jsx (1)

35-35: makeActions is called on every render.

This creates new action objects each render cycle, which could cause unnecessary re-renders of ActionsMenu. Consider memoizing with useMemo.

Proposed fix

- const actions = makeActions([share, rename, remove], { t })
+ const actions = useMemo(() => makeActions([share, rename, remove], { t }), [t])

Add useMemo to the React import:

-import React, { useState, useRef } from 'react'
+import React, { useState, useRef, useMemo } from 'react'

packages/cozy-search/src/components/Conversations/Conversation.jsx (1)

38-43: Nit: object shorthand for component props.

UserMessage: UserMessage and AssistantMessage: AssistantMessage can use ES6 shorthand.

Proposed fix

           <ThreadPrimitive.Messages
             components={{
-              UserMessage: UserMessage,
-              AssistantMessage: AssistantMessage
+              UserMessage,
+              AssistantMessage
             }}
           />

packages/cozy-search/package.json (1)

17-18: classnames and clsx serve the same purpose — consider consolidating.

Both libraries do conditional class-name joining. clsx was likely pulled in alongside the shadcn/assistant-ui patterns while classnames was already in use. Keeping both adds unnecessary bundle weight and creates inconsistency in which utility developers reach for.

Pick one (typically clsx since it's smaller and already required by class-variance-authority) and migrate the classnames call sites.

packages/cozy-search/src/types.d.ts (1)

50-56: useI18n declaration omits additional properties returned by the hook.

From packages/twake-i18n/src/useExtendI18n.jsx, the real hook also returns polyglot (and potentially other fields). The current declaration is fine if only t and lang are used in this package, but consider adding an index signature or a comment noting the partial typing so future consumers aren't surprised.

packages/cozy-search/src/components/Search/helpers.js (1)

23-23: Date.now() fallback silently bins conversations with missing updatedAt into "today".

If a conversation has no cozyMetadata.updatedAt, the fallback to Date.now() will always place it in the "today" group regardless of when it was actually created. If this is intentional, a brief comment would help future readers; otherwise, consider falling back to conv.cozyMetadata?.createdAt or placing such items in "older" as a safer default.

packages/cozy-search/package.json (1)

17-18: Redundant class-name utilities: both classnames and clsx are listed.

These libraries serve the same purpose (conditional class string joining). clsx is smaller and is the one expected by the shadcn/tailwind-merge pattern (cn helper typically wraps clsx + twMerge). Consider migrating existing classnames usage to clsx and dropping the classnames dependency to avoid shipping two libraries that do the same thing.

packages/cozy-search/src/components/TwakeKnowledges/styles.styl (2)

30-35: WebKit-only scrollbar styling — no effect on Firefox.

::-webkit-scrollbar rules are not supported by Firefox. If consistent scrollbar appearance matters, consider adding scrollbar-width: thin and scrollbar-color for Firefox support.

Proposed addition

 .source-panel-content
   flex 1
   overflow-y auto
   padding 0 8px
+  scrollbar-width thin
+  scrollbar-color var(--dividerColor) transparent

   &::-webkit-scrollbar
     width 6px

---

46-51: Heavy !important usage throughout the stylesheet.

Many rules use !important (lines 46-47, 50-51, 54-60, 63-64, 84-85, 88, 91-93). This is common when overriding cozy-ui/MUI defaults, but it makes future style adjustments harder. Consider whether some of these can be replaced with more specific selectors to reduce !important reliance over time.

packages/cozy-search/src/actions/rename.jsx (2)

9-24: makeComponent is duplicated across rename, share, and delete action files.

The makeComponent helper is nearly identical in rename.jsx, share.jsx, and delete.jsx (the only variation being delete.jsx adding className="u-error"). Consider extracting it to a shared utility to reduce duplication.

---

36-36: No-op action handler — consider adding a TODO.

The action callback is an empty function. If this is intentional WIP, a // TODO: implement rename action comment would help other developers understand the incomplete state.

packages/cozy-search/src/components/TwakeKnowledges/TwakeKnowledgePanel.jsx (1)

59-127: Four parallel switch statements on the same key could be a config map.

renderContent, getTitle, getDescription, and getIcon all switch on openedKnowledgePanel. A config object would reduce repetition and make adding new panel types a one-line change.

Example consolidation

+const PANEL_CONFIG = {
+  drive: {
+    titleKey: 'assistant.twake_knowledges.title_drive',
+    descKey: 'assistant.twake_knowledges.desc_drive',
+    icon: TDrive,
+    Component: DriveKnowledge
+  },
+  mail: {
+    titleKey: 'assistant.twake_knowledges.title_mail',
+    descKey: 'assistant.twake_knowledges.desc_mail',
+    icon: TMail,
+    Component: MailKnowledge
+  },
+  chat: {
+    titleKey: 'assistant.twake_knowledges.title_chat',
+    descKey: 'assistant.twake_knowledges.desc_chat',
+    icon: TChat,
+    Component: ChatKnowledge
+  }
+}

Then inside the component:

const config = PANEL_CONFIG[openedKnowledgePanel]
// use config.titleKey, config.icon, config.Component, etc.

packages/cozy-search/src/components/Views/AssistantDialog.jsx (1)

53-60: Consider extracting the inline style to a constant.

A new object is created on every render. Since the values are static, hoist them outside the component or use useMemo.

♻️ Suggested refactor

+const dialogContentStyle = {
+  display: 'flex',
+  flexDirection: 'column',
+  flexGrow: 1,
+  padding: 0
+}
+
 const AssistantDialog = () => {
   ...
       dialogContent: {
-          style: {
-            display: 'flex',
-            flexDirection: 'column',
-            flexGrow: 1,
-            padding: 0
-          }
+          style: dialogContentStyle
        }

packages/cozy-search/src/components/adapters/StreamBridge.ts (2)

74-94: Missing return() method on the async iterator.

When a for-await-of loop is broken (e.g., via break, throw, or return), the engine calls iterator.return() to signal cleanup. Without it, the stream remains open until the adapter explicitly calls cleanup(). Adding return() makes the iterator self-cleaning and more robust if consumed outside the adapter.

♻️ Suggested addition

       iterator: {
         next: (): Promise<IteratorResult<string>> =>
           new Promise((resolve, reject) => {
             // ... existing logic
           }),
+        return: (): Promise<IteratorResult<string>> => {
+          if (!isDone) {
+            isDone = true
+            if (resolveNext) {
+              resolveNext({ value: undefined as unknown as string, done: true })
+              resolveNext = null
+              rejectNext = null
+            }
+          }
+          return Promise.resolve({ value: undefined as unknown as string, done: true })
+        },
         [Symbol.asyncIterator]() {
           return this
         }
       }

---

16-18: Single global cleanupCallback shared across all conversations.

setCleanupCallback stores one callback for the entire bridge. If multiple conversations stream concurrently, cleanup(convA) will invoke the same callback that was perhaps intended for convB. If multi-conversation streaming is a future possibility, consider making the callback per-conversation (e.g., stored in the StreamController).

packages/cozy-search/src/components/adapters/CozyRealtimeChatAdapter.ts (1)

90-95: Abort is only checked between chunks — not while waiting.

If the stream is blocked waiting for the next chunk in next(), the abortSignal.aborted check at line 91 won't run until a chunk arrives. For long pauses this means the UI appears unresponsive to cancellation. Registering an abort event listener that calls streamBridge.cleanup(conversationId) would make cancellation immediate.

♻️ Sketch

+    const onAbort = () => {
+      streamBridge.cleanup(conversationId)
+    }
+    abortSignal?.addEventListener('abort', onAbort, { once: true })
+
     try {
       await client.stackClient.fetchJSON(...)

       // ... for-await loop (remove the inner abortSignal check) ...

     } catch (error) {
       // ...
+    } finally {
+      abortSignal?.removeEventListener('abort', onAbort)
     }

packages/cozy-search/src/components/Views/AssistantView.jsx (1)

14-57: Extract shared dialog rendering logic.

The dialogs section (lines 33–54) is identically duplicated in AssistantDialog.jsx (lines 74–95). Consider extracting into a shared component like AssistantDialogsOverlay to reduce duplication, allowing both views to render the three conditional dialogs without repeating the same markup and logic.

packages/cozy-search/src/components/Conversations/ConversationListItem.jsx (2)

79-83: Inconsistent optional chaining on messages.length.

Line 52 uses conversation.messages?.length (with optional chaining) while line 81 uses conversation.messages.length (without). Although the outer ?.[] short-circuits safely when messages is nullish, the inconsistency is confusing and fragile if refactored later.

Proposed fix

             <Typography className="u-db u-ellipsis u-mb-half u-fz-xsmall">
               {
-                conversation.messages?.[conversation.messages.length - 1]
+                conversation.messages?.[conversation.messages?.length - 1]
                   ?.content
               }
             </Typography>

---

35-35: makeActions is recomputed on every render.

makeActions([share, rename, remove], { t }) creates a new actions array each render. Consider memoizing with useMemo keyed on t to avoid unnecessary work and stable references for ActionsMenu.

Proposed fix

+import React, { useState, useRef, useMemo } from 'react'
...
-  const actions = makeActions([share, rename, remove], { t })
+  const actions = useMemo(() => makeActions([share, rename, remove], { t }), [t])

packages/cozy-search/src/components/Conversations/ConversationListItemWider.jsx (1)

22-38: Significant code duplication with ConversationListItem.jsx.

Both components share identical state management, toggleMenu logic, action creation, imports, and i18n setup. Consider extracting a shared hook (e.g., useConversationItemMenu) to DRY up the common logic.

// e.g., useConversationItemMenu.js
export const useConversationItemMenu = () => {
  const { t, lang } = useI18n()
  const [isMenuOpen, setIsMenuOpen] = useState(false)
  const anchorRef = useRef(null)
  const toggleMenu = e => { e?.stopPropagation(); setIsMenuOpen(!isMenuOpen) }
  const actions = useMemo(() => makeActions([share, rename, remove], { t }), [t])
  return { t, lang, isMenuOpen, anchorRef, toggleMenu, actions }
}

packages/cozy-search/src/components/Conversations/ConversationBar.jsx (2)

71-94: IconButton has no onClick — clicks on its padding area are inert.

The onClick handlers (onCancel on line 79, handleSend on line 91) are bound to the inner Button (rendered as <div>). The outer IconButton has no onClick, so clicking its padding (outside the inner div) does nothing. Consider moving onClick to the IconButton or ensuring the inner div fills the entire clickable area.

---

29-33: Pass the ref object rather than ref.current, or attach the listener in useEffect for clarity.

useEventListener(inputRef.current, 'input', ...) captures undefined during the initial render since the ref hasn't been assigned yet. The listener only gets attached on a subsequent re-render when inputRef.current is populated. While this typically works because the component re-renders on value changes, it's fragile and relies on external re-renders for correctness.

Better patterns:

• Pass the ref object itself and let useEventListener handle dereferencing internally, or
• Move the listener setup into a useEffect that depends on the input element being available